Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: lazy load style on api, utils, and types #2360

Merged
merged 5 commits into from
Oct 31, 2024
Merged

perf: lazy load style on api, utils, and types #2360

merged 5 commits into from
Oct 31, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Oct 31, 2024 •
edited
Loading

before:

In [1]: %time from ape.api import ProjectAPI
CPU times: user 1.04 s, sys: 154 ms, total: 1.19 s
Wall time: 1.19 s

after:

In [1]: %time from ape.api import ProjectAPI
CPU times: user 400 ms, sys: 51.6 ms, total: 452 ms
Wall time: 451 ms
  • Fix docs

@antazoey
Copy link
Member Author

It does seem like tests in Ape are running overall faster from this. Maybe loading modules in a more sparsed way is less CPU load or something, IDK

@antazoey antazoey marked this pull request as ready for review October 31, 2024 17:17
@antazoey antazoey merged commit ebb6473 into ApeWorX:main Oct 31, 2024
16 checks passed
@antazoey antazoey deleted the perf/api-module-fast branch October 31, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antazoey @fubuloubu